Strolch
/
strolch
mirror of https://github.com/strolch-li/strolch.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Bugfix] fixed a resource leak where a BufferedReader was not close 

In FileHelper.readFileToString() the BufferedReader was not closed. This
has been corrected
This commit is contained in:
Robert von Burg 2012-07-28 22:50:52 +02:00
parent c65fe9c247
commit 7dbd5af6a7
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/ch/eitchnet/utils/helper/FileHelper.java
View File

@ -60,9 +60,11 @@ public class FileHelper {
* @return the contents of a file as a string
*/
public static final String readFileToString(File file) {
BufferedReader bufferedReader = null;
try {
BufferedReader bufferedReader = new BufferedReader(new FileReader(file));
bufferedReader = new BufferedReader(new FileReader(file));
StringBuilder sb = new StringBuilder();
String line;
@ -77,6 +79,14 @@ public class FileHelper {
throw new RuntimeException("Filed does not exist " + file.getAbsolutePath());
} catch (IOException e) {
throw new RuntimeException("Could not read file " + file.getAbsolutePath());
} finally {
if (bufferedReader != null) {
try {
bufferedReader.close();
} catch (IOException e) {
logger.error("Failed to close BufferedReader: " + e.getLocalizedMessage());
}
}
}
}