From 7dbd5af6a71ceb84cf8b0b13f5a8599565efede5 Mon Sep 17 00:00:00 2001 From: Robert von Burg Date: Sat, 28 Jul 2012 22:50:52 +0200 Subject: [PATCH] [Bugfix] fixed a resource leak where a BufferedReader was not close In FileHelper.readFileToString() the BufferedReader was not closed. This has been corrected --- .../java/ch/eitchnet/utils/helper/FileHelper.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/main/java/ch/eitchnet/utils/helper/FileHelper.java b/src/main/java/ch/eitchnet/utils/helper/FileHelper.java index 4f310ec8a..66fdc5369 100644 --- a/src/main/java/ch/eitchnet/utils/helper/FileHelper.java +++ b/src/main/java/ch/eitchnet/utils/helper/FileHelper.java @@ -60,9 +60,11 @@ public class FileHelper { * @return the contents of a file as a string */ public static final String readFileToString(File file) { + + BufferedReader bufferedReader = null; try { - BufferedReader bufferedReader = new BufferedReader(new FileReader(file)); + bufferedReader = new BufferedReader(new FileReader(file)); StringBuilder sb = new StringBuilder(); String line; @@ -77,6 +79,14 @@ public class FileHelper { throw new RuntimeException("Filed does not exist " + file.getAbsolutePath()); } catch (IOException e) { throw new RuntimeException("Could not read file " + file.getAbsolutePath()); + } finally { + if (bufferedReader != null) { + try { + bufferedReader.close(); + } catch (IOException e) { + logger.error("Failed to close BufferedReader: " + e.getLocalizedMessage()); + } + } } }