From f1216f882503c85215646e4a7668efa8f1275432 Mon Sep 17 00:00:00 2001 From: Robert von Burg Date: Tue, 16 May 2017 14:28:32 +0200 Subject: [PATCH] [Major] Now throwing exception if TX is not committed but has commands --- .../li/strolch/persistence/api/AbstractTransaction.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/li.strolch.agent/src/main/java/li/strolch/persistence/api/AbstractTransaction.java b/li.strolch.agent/src/main/java/li/strolch/persistence/api/AbstractTransaction.java index 8453ee843..c868af6ec 100644 --- a/li.strolch.agent/src/main/java/li/strolch/persistence/api/AbstractTransaction.java +++ b/li.strolch.agent/src/main/java/li/strolch/persistence/api/AbstractTransaction.java @@ -723,12 +723,10 @@ public abstract class AbstractTransaction implements StrolchTransaction { try { this.txResult.setState(TransactionState.CLOSING); - // TODO re-think this. if (!this.commands.isEmpty()) { - logger.error( - "There are commands registered on a read-only transaction. Changing to rollback! Probably due to an exception!"); autoCloseableRollback(); - return; + String msg = "There are commands registered on a read-only transaction. Changing to rollback! Probably due to an exception!"; + throw new IllegalStateException(msg); } long auditTrailDuration = writeAuditTrail();