From ea81b26916ea6e3542eb9abca258efa991dbb82d Mon Sep 17 00:00:00 2001 From: Robert von Burg Date: Tue, 29 May 2018 10:15:17 +0200 Subject: [PATCH] [Minor] Replace ListParameter values on setValue() --- .../java/li/strolch/model/parameter/FloatListParameter.java | 6 +----- .../li/strolch/model/parameter/IntegerListParameter.java | 6 +----- .../java/li/strolch/model/parameter/LongListParameter.java | 6 +----- .../li/strolch/model/parameter/StringListParameter.java | 6 +----- 4 files changed, 4 insertions(+), 20 deletions(-) diff --git a/li.strolch.model/src/main/java/li/strolch/model/parameter/FloatListParameter.java b/li.strolch.model/src/main/java/li/strolch/model/parameter/FloatListParameter.java index bbf0d98fe..40d3042d8 100644 --- a/li.strolch.model/src/main/java/li/strolch/model/parameter/FloatListParameter.java +++ b/li.strolch.model/src/main/java/li/strolch/model/parameter/FloatListParameter.java @@ -88,11 +88,7 @@ public class FloatListParameter extends AbstractParameter> implemen public void setValue(List value) { assertNotReadonly(); validateValue(value); - if (this.value == null) { - this.value = new ArrayList<>(value.size()); - } - this.value.clear(); - this.value.addAll(value); + this.value = new ArrayList<>(value.size()); } @Override diff --git a/li.strolch.model/src/main/java/li/strolch/model/parameter/IntegerListParameter.java b/li.strolch.model/src/main/java/li/strolch/model/parameter/IntegerListParameter.java index ef2e0d819..cd0dae6d0 100644 --- a/li.strolch.model/src/main/java/li/strolch/model/parameter/IntegerListParameter.java +++ b/li.strolch.model/src/main/java/li/strolch/model/parameter/IntegerListParameter.java @@ -88,11 +88,7 @@ public class IntegerListParameter extends AbstractParameter> imple public void setValue(List value) { assertNotReadonly(); validateValue(value); - if (this.value == null) { - this.value = new ArrayList<>(value.size()); - } - this.value.clear(); - this.value.addAll(value); + this.value = new ArrayList<>(value.size()); } @Override diff --git a/li.strolch.model/src/main/java/li/strolch/model/parameter/LongListParameter.java b/li.strolch.model/src/main/java/li/strolch/model/parameter/LongListParameter.java index 8b6e276fc..e60105220 100644 --- a/li.strolch.model/src/main/java/li/strolch/model/parameter/LongListParameter.java +++ b/li.strolch.model/src/main/java/li/strolch/model/parameter/LongListParameter.java @@ -88,11 +88,7 @@ public class LongListParameter extends AbstractParameter> implements public void setValue(List value) { assertNotReadonly(); validateValue(value); - if (this.value == null) { - this.value = new ArrayList<>(value.size()); - } - this.value.clear(); - this.value.addAll(value); + this.value = new ArrayList<>(value.size()); } @Override diff --git a/li.strolch.model/src/main/java/li/strolch/model/parameter/StringListParameter.java b/li.strolch.model/src/main/java/li/strolch/model/parameter/StringListParameter.java index 7c790c26d..377a340d4 100644 --- a/li.strolch.model/src/main/java/li/strolch/model/parameter/StringListParameter.java +++ b/li.strolch.model/src/main/java/li/strolch/model/parameter/StringListParameter.java @@ -88,11 +88,7 @@ public class StringListParameter extends AbstractParameter> impleme public void setValue(List value) { assertNotReadonly(); validateValue(value); - if (this.value == null) { - this.value = new ArrayList<>(value.size()); - } - this.value.clear(); - this.value.addAll(value); + this.value = new ArrayList<>(value.size()); } @Override