From ba476b2f681625ce52c1f8b4853d9ef764bb95a4 Mon Sep 17 00:00:00 2001 From: Robert von Burg Date: Fri, 7 Oct 2016 09:38:28 +0200 Subject: [PATCH] [Minor] Added TODO about .getBy() which returns clone, and querying --- .../src/main/java/li/strolch/agent/impl/CachedElementMap.java | 1 + .../java/li/strolch/agent/impl/TransactionalElementMap.java | 1 + .../src/main/java/li/strolch/agent/impl/TransactionalRealm.java | 1 - .../java/li/strolch/runtime/query/inmemory/InMemoryQuery.java | 2 ++ 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/li.strolch.agent/src/main/java/li/strolch/agent/impl/CachedElementMap.java b/li.strolch.agent/src/main/java/li/strolch/agent/impl/CachedElementMap.java index 04df1daf4..daabe57c5 100644 --- a/li.strolch.agent/src/main/java/li/strolch/agent/impl/CachedElementMap.java +++ b/li.strolch.agent/src/main/java/li/strolch/agent/impl/CachedElementMap.java @@ -118,6 +118,7 @@ public abstract class CachedElementMap implements if (t == null) return null; + // TODO cloning has its issues, as queries don't return a clone! @SuppressWarnings("unchecked") T clone = (T) t.getClone(); clone.setVersion(t.getVersion()); diff --git a/li.strolch.agent/src/main/java/li/strolch/agent/impl/TransactionalElementMap.java b/li.strolch.agent/src/main/java/li/strolch/agent/impl/TransactionalElementMap.java index 19c3e30ce..6c4730a83 100644 --- a/li.strolch.agent/src/main/java/li/strolch/agent/impl/TransactionalElementMap.java +++ b/li.strolch.agent/src/main/java/li/strolch/agent/impl/TransactionalElementMap.java @@ -118,6 +118,7 @@ public abstract class TransactionalElementMap impl if (!this.realm.getMode().isTransient()) return t; + // TODO cloning has its issues, as queries don't return a clone! @SuppressWarnings("unchecked") T clone = (T) t.getClone(); clone.setVersion(t.getVersion()); diff --git a/li.strolch.agent/src/main/java/li/strolch/agent/impl/TransactionalRealm.java b/li.strolch.agent/src/main/java/li/strolch/agent/impl/TransactionalRealm.java index 8b5e9cc27..323306285 100644 --- a/li.strolch.agent/src/main/java/li/strolch/agent/impl/TransactionalRealm.java +++ b/li.strolch.agent/src/main/java/li/strolch/agent/impl/TransactionalRealm.java @@ -26,7 +26,6 @@ import li.strolch.persistence.api.PersistenceHandler; import li.strolch.persistence.api.StrolchTransaction; import li.strolch.privilege.model.Certificate; import li.strolch.privilege.model.PrivilegeContext; -import li.strolch.runtime.StrolchConstants; import li.strolch.runtime.configuration.ComponentConfiguration; import li.strolch.utils.dbc.DBC; import li.strolch.utils.helper.StringHelper; diff --git a/li.strolch.agent/src/main/java/li/strolch/runtime/query/inmemory/InMemoryQuery.java b/li.strolch.agent/src/main/java/li/strolch/runtime/query/inmemory/InMemoryQuery.java index 875247759..d497839a3 100644 --- a/li.strolch.agent/src/main/java/li/strolch/runtime/query/inmemory/InMemoryQuery.java +++ b/li.strolch.agent/src/main/java/li/strolch/runtime/query/inmemory/InMemoryQuery.java @@ -92,6 +92,8 @@ public class InMemoryQuery { } } + // TODO The ElementMaps return a clone, but here we don't... + return result; } }