Strolch
/
strolch
mirror of https://github.com/strolch-li/strolch.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[New] Added Action.isResourceDefined() and additional JavaDoc

This commit is contained in:
Robert von Burg 2022-01-19 19:30:13 +01:00
parent d7bd8bba39
commit b425414b74
1 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
li.strolch.model/src/main/java/li/strolch/model/activity/Action.java
View File

@ -146,12 +146,33 @@ public class Action extends GroupedParameterizedElement implements IActivityElem
this.resourceId = resource.getId();
}
/**
* @deprecated use {@link #isResourceDefined()}
*/
@Deprecated
public boolean hasResourceDefined() {
return isNotEmpty(this.resourceType) && isNotEmpty(this.resourceId);
}
/**
* Returns true if the {@link #getResourceType()} and {@link #getResourceId()} have defined values
*
* @return true if the {@link #getResourceType()} and {@link #getResourceId()} have defined values
*/
public boolean isResourceDefined() {
return isNotEmpty(this.resourceType) && isNotEmpty(this.resourceId);
}
/**
* Returns the {@link Locator} for the {@link Resource} for this action
*
* @return the {@link Locator} for the {@link Resource} for this action
*
* @throws IllegalStateException
* if the resource is not defined
*/
public Locator getResourceLocator() {
if (!hasResourceDefined())
if (!isResourceDefined())
throw new IllegalStateException("Resource not set on " + getLocator());
return Resource.locatorFor(this.resourceType, this.resourceId);
}
@ -186,6 +207,9 @@ public class Action extends GroupedParameterizedElement implements IActivityElem
return this.changes;
}
/**
* @return the iterator of {@code IValueChange} attached to the {@code Action} start
*/
public Iterator<IValueChange<? extends IValue<?>>> changesIterator() {
if (this.changes == null)
return Collections.emptyIterator();