From 97a0c076a44a010cebf1e261a2ed20eac65cef68 Mon Sep 17 00:00:00 2001 From: Robert von Burg Date: Fri, 8 Sep 2017 18:48:53 +0200 Subject: [PATCH] [Minor] Throw exception if forget to commit --- .../li/strolch/persistence/api/AbstractTransaction.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/li.strolch.agent/src/main/java/li/strolch/persistence/api/AbstractTransaction.java b/li.strolch.agent/src/main/java/li/strolch/persistence/api/AbstractTransaction.java index accaaee4c..6e054a690 100644 --- a/li.strolch.agent/src/main/java/li/strolch/persistence/api/AbstractTransaction.java +++ b/li.strolch.agent/src/main/java/li/strolch/persistence/api/AbstractTransaction.java @@ -928,7 +928,13 @@ public abstract class AbstractTransaction implements StrolchTransaction { if (!this.commands.isEmpty()) { autoCloseableRollback(); - String msg = "There are commands registered on a read-only transaction. Changing to rollback! Probably due to an exception!"; + String msg = "There are commands registered on a read-only transaction. Changing to rollback! Did you forget to commit?"; + throw new IllegalStateException(msg); + } + + if (!this.objectFilter.isEmpty()) { + autoCloseableRollback(); + String msg = "There are modified objects registered on a read-only transaction. Changing to rollback! Did you forget to commit?"; throw new IllegalStateException(msg); }