From 936ce8ca8b379affe4d76708b3caccfd4b83b915 Mon Sep 17 00:00:00 2001
From: Robert von Burg <eitch@eitchnet.ch>
Date: Thu, 19 Sep 2019 21:39:54 +0200
Subject: [PATCH] [Fix] Fixed binaryTo*() due to not parsing in reverse

---
 .../li/strolch/utils/helper/StringHelper.java | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/li.strolch.utils/src/main/java/li/strolch/utils/helper/StringHelper.java b/li.strolch.utils/src/main/java/li/strolch/utils/helper/StringHelper.java
index 29a3b4d8a..9a3a339e4 100644
--- a/li.strolch.utils/src/main/java/li/strolch/utils/helper/StringHelper.java
+++ b/li.strolch.utils/src/main/java/li/strolch/utils/helper/StringHelper.java
@@ -206,13 +206,27 @@ public class StringHelper {
 		return b;
 	}
 
+	public static char binaryToChar(String binary) {
+		if (binary.indexOf(' ') != -1)
+			binary = binary.replaceAll(" ", "");
+		if (binary.length() != Byte.SIZE && binary.length() != Short.SIZE)
+			throw new IllegalArgumentException("char as binary must be 8 or 16 chars long!");
+		int b = 0;
+		for (int i = 0; i < binary.length(); i++) {
+			if (binary.charAt((binary.length() - 1) - i) == '1')
+				b = setBit(b, i);
+		}
+
+		return (char) b;
+	}
+
 	public static short binaryToShort(String binary) {
 		binary = binary.replaceAll(" ", "");
 		if (binary.length() != Short.SIZE)
 			throw new IllegalArgumentException("Short as binary must be 8 chars long!");
 		short b = 0;
 		for (int i = 0; i < Short.SIZE; i++) {
-			if (binary.charAt(i) == '1')
+			if (binary.charAt((Short.SIZE - 1) - i) == '1')
 				b = setBit(b, i);
 		}
 
@@ -225,7 +239,7 @@ public class StringHelper {
 			throw new IllegalArgumentException("Integer as binary must be 8 chars long!");
 		int b = 0;
 		for (int i = 0; i < Integer.SIZE; i++) {
-			if (binary.charAt(i) == '1')
+			if (binary.charAt((Integer.SIZE - 1) - i) == '1')
 				b = setBit(b, i);
 		}
 
@@ -869,5 +883,4 @@ public class StringHelper {
 		return uniqueId;
 	}
 
-
 }