From 5be5cd3fa098ff7a978e7553b949fe3f916af9e6 Mon Sep 17 00:00:00 2001 From: Robert von Burg Date: Sat, 19 Oct 2013 17:49:27 +0200 Subject: [PATCH] [Minor] fixed compiler warnings --- src/main/java/ch/eitchnet/xmlpers/api/IoMode.java | 8 ++++++++ .../ch/eitchnet/xmlpers/api/TransactionCloseStrategy.java | 3 +++ .../java/ch/eitchnet/xmlpers/objref/IdOfSubTypeRef.java | 1 + src/main/java/ch/eitchnet/xmlpers/objref/IdOfTypeRef.java | 1 + src/main/java/ch/eitchnet/xmlpers/objref/SubTypeRef.java | 1 + src/main/java/ch/eitchnet/xmlpers/objref/TypeRef.java | 1 + src/test/java/ch/eitchnet/xmlpers/test/FileDaoTest.java | 7 +++---- 7 files changed, 18 insertions(+), 4 deletions(-) diff --git a/src/main/java/ch/eitchnet/xmlpers/api/IoMode.java b/src/main/java/ch/eitchnet/xmlpers/api/IoMode.java index 7464bff31..2b80e64b0 100644 --- a/src/main/java/ch/eitchnet/xmlpers/api/IoMode.java +++ b/src/main/java/ch/eitchnet/xmlpers/api/IoMode.java @@ -50,10 +50,18 @@ public enum IoMode { } }; + /** + * @param ctx + * @param fileIo + */ public void write(PersistenceContext ctx, FileIo fileIo) { throw new UnsupportedOperationException("Override me!"); //$NON-NLS-1$ } + /** + * @param ctx + * @param fileIo + */ public void read(PersistenceContext ctx, FileIo fileIo) { throw new UnsupportedOperationException("Override me!"); //$NON-NLS-1$ } diff --git a/src/main/java/ch/eitchnet/xmlpers/api/TransactionCloseStrategy.java b/src/main/java/ch/eitchnet/xmlpers/api/TransactionCloseStrategy.java index a535fe5c6..7f93e02a9 100644 --- a/src/main/java/ch/eitchnet/xmlpers/api/TransactionCloseStrategy.java +++ b/src/main/java/ch/eitchnet/xmlpers/api/TransactionCloseStrategy.java @@ -15,6 +15,9 @@ public enum TransactionCloseStrategy { } }; + /** + * @param tx + */ public void close(PersistenceTransaction tx) { throw new UnsupportedOperationException("Override in enum!"); //$NON-NLS-1$ } diff --git a/src/main/java/ch/eitchnet/xmlpers/objref/IdOfSubTypeRef.java b/src/main/java/ch/eitchnet/xmlpers/objref/IdOfSubTypeRef.java index d2c4b37a6..8312a93da 100644 --- a/src/main/java/ch/eitchnet/xmlpers/objref/IdOfSubTypeRef.java +++ b/src/main/java/ch/eitchnet/xmlpers/objref/IdOfSubTypeRef.java @@ -22,6 +22,7 @@ public class IdOfSubTypeRef extends ObjectRef { this.id = id; } + @Override public String getType() { return this.type; } diff --git a/src/main/java/ch/eitchnet/xmlpers/objref/IdOfTypeRef.java b/src/main/java/ch/eitchnet/xmlpers/objref/IdOfTypeRef.java index 40db517c3..a6f09dbef 100644 --- a/src/main/java/ch/eitchnet/xmlpers/objref/IdOfTypeRef.java +++ b/src/main/java/ch/eitchnet/xmlpers/objref/IdOfTypeRef.java @@ -20,6 +20,7 @@ public class IdOfTypeRef extends ObjectRef { this.id = id; } + @Override public String getType() { return this.type; } diff --git a/src/main/java/ch/eitchnet/xmlpers/objref/SubTypeRef.java b/src/main/java/ch/eitchnet/xmlpers/objref/SubTypeRef.java index 29064486c..560526b3d 100644 --- a/src/main/java/ch/eitchnet/xmlpers/objref/SubTypeRef.java +++ b/src/main/java/ch/eitchnet/xmlpers/objref/SubTypeRef.java @@ -18,6 +18,7 @@ public class SubTypeRef extends ObjectRef { this.subType = subType; } + @Override public String getType() { return this.type; } diff --git a/src/main/java/ch/eitchnet/xmlpers/objref/TypeRef.java b/src/main/java/ch/eitchnet/xmlpers/objref/TypeRef.java index 6a588527f..44e2770a1 100644 --- a/src/main/java/ch/eitchnet/xmlpers/objref/TypeRef.java +++ b/src/main/java/ch/eitchnet/xmlpers/objref/TypeRef.java @@ -16,6 +16,7 @@ public class TypeRef extends ObjectRef { this.type = type; } + @Override public String getType() { return this.type; } diff --git a/src/test/java/ch/eitchnet/xmlpers/test/FileDaoTest.java b/src/test/java/ch/eitchnet/xmlpers/test/FileDaoTest.java index 2ba28bcd7..150b18f36 100644 --- a/src/test/java/ch/eitchnet/xmlpers/test/FileDaoTest.java +++ b/src/test/java/ch/eitchnet/xmlpers/test/FileDaoTest.java @@ -80,7 +80,7 @@ public class FileDaoTest extends AbstractPersistenceTest { try (PersistenceTransaction tx = new DefaultPersistenceTransaction(this.realm, VERBOSE)) { FileDao fileDao = new FileDao(tx, this.pathBuilder, VERBOSE); tx.setIoMode(IoMode.SAX); - testCrud(tx, this.realm.getCtxFactoryDelegator(), fileDao); + testCrud(this.realm.getCtxFactoryDelegator(), fileDao); } } @@ -90,12 +90,11 @@ public class FileDaoTest extends AbstractPersistenceTest { try (PersistenceTransaction tx = new DefaultPersistenceTransaction(this.realm, VERBOSE)) { FileDao fileDao = new FileDao(tx, this.pathBuilder, VERBOSE); tx.setIoMode(IoMode.DOM); - testCrud(tx, this.realm.getCtxFactoryDelegator(), fileDao); + testCrud(this.realm.getCtxFactoryDelegator(), fileDao); } } - private void testCrud(PersistenceTransaction tx, PersistenceContextFactoryDelegator ctxFactoryDelegator, - FileDao fileDao) { + private void testCrud(PersistenceContextFactoryDelegator ctxFactoryDelegator, FileDao fileDao) { Resource resource = createResource(); assertResource(resource);