Strolch
/
strolch
mirror of https://github.com/strolch-li/strolch.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Minor] throw exception if declared dependency is missing 

Instead of running into a NPE, now an exception is thrown so the user
knows which component is missing which dependency.
This commit is contained in:
Robert von Burg 2013-11-16 01:09:44 +01:00
parent 81960291e7
commit 548a34b9f3
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/java/li/strolch/runtime/component/ComponentDependencyAnalyzer.java
View File

@ -1,5 +1,6 @@
package li.strolch.runtime.component;
import java.text.MessageFormat;
import java.util.HashSet;
import java.util.Iterator;
import java.util.Map;
@ -7,6 +8,7 @@ import java.util.Set;
import li.strolch.runtime.configuration.ComponentConfiguration;
import li.strolch.runtime.configuration.StrolchConfiguration;
import li.strolch.runtime.configuration.StrolchConfigurationException;
public class ComponentDependencyAnalyzer {
@ -109,6 +111,11 @@ public class ComponentDependencyAnalyzer {
Set<String> dependencies = configuration.getDependencies();
for (String dependencyName : dependencies) {
ComponentController dependency = this.controllerMap.get(dependencyName);
if (dependency == null) {
String msg = "Component {0} is missing required dependency {1}"; //$NON-NLS-1$
msg = MessageFormat.format(msg, name, dependencyName);
throw new StrolchConfigurationException(msg);
}
controller.addUpstreamDependency(dependency);
}
}